Fix #5859 (Melt crashes melting MSIs with elevated privileges) #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
BMurri
reviewed
Aug 28, 2018
| @@ -84,17 +84,16 @@ public static Pdb Load(string path, bool suppressVersionCheck, bool suppressSche | |||
| internal static Pdb Load(Stream stream, Uri uri, bool suppressVersionCheck, bool suppressSchema) | |||
| { | |||
| XmlReader reader = null; | |||
| TempFileCollection tempFileCollection = null; | |||
There was a problem hiding this comment.
Not critical, but I would recommend a try/finally wherein you dispose of the TempFileCollection if it is not assigned to pdb.Output.TempFiles
barnson
force-pushed
the
develop
branch
4 times, most recently
from
f5d73ed
to
90c9809
Compare
|
Thanks for providing this patch 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug where melt.exe crashes when attempting to write to a temporary file in a temporary directory that no longer exists. TempFileCollection will create a sub-directory in %TMP% when run with elevated UAC privileges and when the instance of TempFileCollection is deleted the sub-directory is also deleted.